Remove is_bad_addr from connection_new's error
#785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #529, the implementation of
connection_newsimply parses the multiaddress passed as parameter than notifies the upper layers that a connection must be opened.If the connection couldn't be opened, the upper layers later call
connection_reset.The Rust code properly translates an error in
connection_newas returning an error whereis_bad_addr: true, and translates a later call toconnection_resetas returning an error whereis_bad_addr: false.What this PR does is remove the fact that the error returned by
connection_newcan haveis_bad_addr: true, as this is in practice never the case anymore.